Skip to content

test:add ci for cleanup fifos #4443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ningmingxiao
Copy link
Contributor

@ningmingxiao ningmingxiao commented Aug 5, 2025

add some ci for #4316

@ningmingxiao ningmingxiao force-pushed the add_ci branch 2 times, most recently from c4a36e1 to caea35f Compare August 5, 2025 02:28
@fahedouch
Copy link
Member

is it possible to fix on the same PR #4316 ?

@ningmingxiao
Copy link
Contributor Author

ningmingxiao commented Aug 5, 2025

is it possible to fix on the same PR #4316 ?
pr 4316 long time noby answer, you can mege it and then merge my pr.
and i think we should call io.Close() after @fahedouch

case status := <-exitCh:

@ningmingxiao ningmingxiao force-pushed the add_ci branch 3 times, most recently from 1d87452 to 34ba006 Compare August 5, 2025 09:39
Signed-off-by: ningmingxiao <[email protected]>
@fahedouch
Copy link
Member

Some suggestions:

  • Close IO even when task is already Stopped:

    • In Stop, for the early return case case containerd.Stopped, consider closing IO before returning to prevent leaving FIFOs up until another path cleans them:
      • Example change:
        • Before return nil for containerd.Stopped, do:
          • if io := task.IO(); io != nil { if err := io.Close(); err != nil { log.Warnf(...) } }
    • Some shims/plugins may leave IO present until an explicit close; proactively closing avoids FIFO linger in this rare path.
  • Log levels/messages:

    • The warning on IO close failure is good. Optionally include more context (namespace, task pid if available) for easier troubleshooting.

@fahedouch
Copy link
Member

fahedouch commented Aug 12, 2025

CI is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants